Skip to content

fix: details summary arrow #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: details summary arrow #1479

merged 2 commits into from
Feb 27, 2025

Conversation

@katzino
Copy link
Contributor

@katzino katzino commented Feb 26, 2025

Closes #1475

I ejected Details component via swizzle command

@katzino katzino added bug Something isn't working. t-web Issues with this label are in the ownership of the web team. labels Feb 26, 2025
@katzino katzino added this to the 109th sprint - Web Team milestone Feb 26, 2025
@katzino katzino self-assigned this Feb 26, 2025
@jbartadev jbartadev requested review from barjin and removed request for jbartadev February 26, 2025 10:41
barjin
barjin reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity - have you guys found a reason why is it like that? Is it the <html font-size="10px" still biting us? Or is it some newer changes? I see this has been with us since last September at least.

Either way, as long as it looks as it should, I'm pro-merge here :)

@katzino
Copy link
Contributor Author

katzino commented Feb 26, 2025

Out of curiosity - have you guys found a reason why is it like that? Is it the <html font-size="10px" still biting us? Or is it some newer changes? I see this has been with us since last September at least.

Either way, as long as it looks as it should, I'm pro-merge here :)

I genuinely have no idea. This broken arrow size variable had value of .38rem; which doesn't make sense neither for 10px nor 16px font size. Seems like a bug on their default styling 🤷‍♂️

@katzino katzino merged commit 7ce8c41 into master Feb 27, 2025
7 checks passed
@katzino katzino deleted the fix/details-summary-arrow branch February 27, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barjin barjin barjin left review comments

@webrdaniel webrdaniel webrdaniel approved these changes

Assignees

@katzino katzino

Labels

bug Something isn't working. t-web Issues with this label are in the ownership of the web team.

Projects

None yet

Milestone

109th sprint - Web Team

Development

Successfully merging this pull request may close these issues.

Collapse and expand button is really small

4 participants

@katzino @barjin @webrdaniel